[gstreamer-bugs] [Bug 363119] [Audiorate] rounding errors cause 'clicking' in sound

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=363119

  GStreamer | gst-plugins-base | Ver: HEAD CVS





------- Comment #3 from Tim-Philipp Müller  2006-10-21 16:44 UTC -------
Added some fairly basic test cases:

  2006-10-21  Tim-Philipp Müller  <tim at centricular dot net>

        * tests/check/Makefile.am:
        * tests/check/elements/.cvsignore:
        * tests/check/elements/audiorate.c: (probe_cb), (got_buf),
        (do_perfect_stream_test), (GST_START_TEST), (audiorate_suite):
          Add some basic unit tests for audiorate. Disabled at the moment
          since it doesn't pass yet (see bug #363119).

Patch seems to work great to fix up the stream for the normal case, but there
appear to be one or two corner-cases where it fails with an off-by-one offset
when buffers get dropped (might be a bug in the unit test though, haven't
really looked into it).

Btw, %lld and %llu aren't really portable in printf statements, better to use
"%" G_GINT64_FORMAT  and "%" G_GUINT64_FORMAT.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email