[gstreamer-bugs] [Bug 366155] [matroskademux] Several problems in encoding handling code

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=366155

  GStreamer | gst-plugins-good | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75556|none                        |committed
               Flag|                            |
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.5




------- Comment #2 from Tim-Philipp Müller  2006-10-30 16:39 UTC -------
Looks good, thanks.

 2006-10-30  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Michal Benes  <michal dot benes at itonis tv>

        * gst/matroska/matroska-demux.c: (gst_matroska_demux_encoding_cmp),
        (gst_matroska_demux_read_track_encodings),
        (gst_matroska_decode_buffer):
          Fix several issues with encoded/compressed/encrypted/signed tracks;
          also, remove superfluous newline characters from some debug
          statements. (#366155)


I'm not entirely sure what to do about buffers we can't decode or decompress. I
am not really sure whether it's a good idea to push them as they are (as
opposed to just dropping them).

We might also want some check in place to ensure that there is at least one
track we can decode and throw an error if not.

It seems that according to the spec EncodingType == 1 && ContentEncAlgo == 0
means that the buffers are signed rather than encrypted. Is this what you meant
or are there more cases?

Not printing the warning for every buffer would indeed be a good idea. Care to
make a patch for that too? :)

Btw, if you happen to have some (not so big) sample files that use track
encodings/compressions/encryptions, I'd be quite interested to get my hands on
them.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email