[gstreamer-bugs] [Bug 357617] [libs] gst_controller_set_from_list can return without unlocking the mutex

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=357617

GStreamer | gstreamer (core) | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73374|0                           |1
        is obsolete|                            |
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.11




------- Comment #3 from Tim-Philipp Müller  2006-09-29 12:32 UTC -------
Thanks for the patch! Went with a slightly different solution though :)

 2006-09-29  Tim-Philipp Müller  <tim at centricular dot net>

        * tests/check/libs/controller.c: (GST_START_TEST),
        (gst_controller_suite):
          Add test for the previous fix; add some more tests
          for correct refcounting behaviour; fix a few leaks
          in test cases; call gst_controller_init() at start
          of all tests.

 2006-09-29  Tim-Philipp Müller  <tim at centricular dot net>

        * libs/gst/controller/gstcontroller.c: (gst_controller_new_valist),
        (gst_controller_set_from_list):
          Don't g_return_val_if_fail() on timed values with invalid timestamps
          inside a critical section without unlocking the mutex. Spotted by
          René Stadler. (#357617)
          Also, fix up refcounting properly: when returning an existing
          controller, we should increase the reference only once and not
          once per property and when trying to control a property again
          we should also increase the refcount.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.