[gstreamer-bugs] [Bug 445529] [volume] support for 24/32-bit audio/x-raw-int

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=445529

  GStreamer | gst-plugins-base | Ver: HEAD CVS




------- Comment #5 from Sebastian Dröge  2007-08-23 07:50 UTC -------
Oh, and the negative minimum values are always in absolute one larger than the
positive maximums, i.e. 
+#define VOLUME_MAX_INT32             2147483647
+#define VOLUME_MIN_INT32             -2147483646
+#define VOLUME_MAX_INT24             8388607
+#define VOLUME_MIN_INT24             -8388606

should be

+#define VOLUME_MAX_INT32             2147483647
+#define VOLUME_MIN_INT32             -2147483648
+#define VOLUME_MAX_INT24             8388607
+#define VOLUME_MIN_INT24             -8388608

Also I'm not sure about the bitshift stuff in the very beginning of the patch,
would be better if someone who understands it looks at this too :)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=445529.