[gstreamer-bugs] [Bug 407433] possibly obsolete code in avidemux

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=407433

  GStreamer | gst-plugins-good | Ver: HEAD CVS





------- Comment #4 from Ronald Bultje  2007-02-13 15:02 UTC -------
Stefan,

do not touch code that you don't understand unless you asked the person that
wrote it. Email the author or see the ChangeLog entry of the commit if you're
not sure. This code is used by those AVI files that have a single audio chunk
(I'm not sure if the code used an if (audio), but it quite definitely uses a if
(num_frames == 1) for index expansion). This is valid and such files exist. The
code above allows seeking in those files, and in some cases makes audio not
hang the video thread (thus blocking the whole pipeline on input - this would
happen to 0.10 as well). AVI files are available in bugzilla (see ChangeLog of
said commit) or in mplayerhq.hu.

I've already explained on the mailinglist how to reduce memory usage by ~98,5%
using decent methods, try that and leave this code alone, please.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email