[gstreamer-bugs] [Bug 357503] [suparse] wrong timing with microdvd subtitles
GStreamer (bugzilla.gnome.org)
bugzilla-daemon at bugzilla.gnome.org
Mon Jan 8 04:33:53 PST 2007
Do not reply to this via email (we are currently unable to handle email
responses and they get discarded). You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=357503
GStreamer | gst-plugins-base | Ver: 0.10.10
Tim-Philipp Müller changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Summary|Problem with microdvd |[suparse] wrong timing with
|subtitles |microdvd subtitles
Target Milestone|HEAD |0.10.12
------- Comment #6 from Tim-Philipp Müller 2007-01-08 12:32 UTC -------
> No, it doesn't. But adding it doesn't seem to make any difference either.
Not surprising, since the code doesn't look for a framerate in the first line
yet :)
I've committed this now:
2007-01-08 Tim-Philipp Müller <tim at centricular dot net>
* gst/subparse/gstsubparse.c: (parse_mdvdsub):
* gst/subparse/gstsubparse.h:
Remove spurious 1000 subtrahend when calculating the timestamp from
the frame number and the frame rate . Also, use the frames/second
value specified in the first line of the file, if one is specified
there. Should fix #357503.
* tests/check/elements/subparse.c: (do_test),
(test_tmplayer_do_test), (test_microdvd_do_test), (GST_START_TEST),
(subparse_suite):
Add some basic unit tests for the microdvd subtitle format.
Please file new bugs if you find any further issues.
--
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
More information about the Gstreamer-bugs
mailing list