[gstreamer-bugs] [Bug 336370] [asfdemux] crashes on an assertion in gst_asf_demux_get_var_length

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=336370

  GStreamer | gst-plugins-ugly | Ver: 0.10.2


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81027|0                           |1
        is obsolete|                            |




------- Comment #66 from Tim-Philipp Müller  2007-01-24 17:45 UTC -------
Created an attachment (id=81095)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=81095&action=view)
same as above, but fixed checks before calls to gst_asf_demux_get_var_length()

Tbhanks a lot for this patch!

Unfortunately it doesn't entirely fix the issue for me, I still get asserts for
this file for example, played locally from file:

  http://gstreamer.freedesktop.org/media/incoming/336370-jojolidol.wmv

The required size calculation before the gst_asf_demux_get_var_length() wasn't
entirely correct as far as I can see (required_size is 4 bytes when the value
is 3, not 3 bytes). After fixing that up, the problem disappears for me as
well.

Attached the updated patch.


> (but the demuxer as a whole obviously needs way more work to be robust.)

No doubt about it. I've started working on a bit of a rewrite, but it's
probably going to be a while before that's ready.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email