[gstreamer-bugs] [Bug 407349] [id3demux] wrongly interprets TDAT as year

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=407349

  GStreamer | gst-plugins-good | Ver: 0.10.3


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83621|0                           |1
        is obsolete|                            |
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Summary|id3demux reports incorrect  |[id3demux] wrongly
                   |year when TDAT is present   |interprets TDAT as year
   Target Milestone|HEAD                        |0.10.6




------- Comment #5 from Tim-Philipp Müller  2007-03-06 23:24 UTC -------
Should be fixed now:

  2007-03-06  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/id3demux/id3tags.c: (id3demux_id3v2_frames_to_tag_list):
        * gst/id3demux/id3tags.h:
        * gst/id3demux/id3v2frames.c: (id3demux_id3v2_parse_frame),
        (parse_obsolete_tdat_frame):
          Do not convert obsolete TDA/TDAT frames to TDRC frames, otherwise
          the four-digit number will be interpreted as a year, whereas it is
          month and day in DDMM format. Instead, parse TDAT frames and fix up
          the date in the GST_TAG_DATE tag later if we also extracted a year.
          Fixes #407349.


2007-03-06  Tim-Philipp Müller  <tim at centricular dot net>

        * configure.ac:
        * tests/files/Makefile.am:
        * tests/files/id3-407349-1.tag:
        * tests/files/id3-407349-2.tag:
          Add directory where data for unit tests can be stored.

        * tests/Makefile.am:
        * tests/check/Makefile.am:
        * tests/check/elements/.cvsignore:
        * tests/check/elements/id3demux.c: (pad_added_cb), (error_cb),
        (read_tags_from_file), (run_check_for_file),
        (check_date_1977_06_23), (GST_START_TEST), (id3demux_suite):
          Add unit test for id3demux, and in particular for bug #407349. Only
          testing pull-mode for now; push mode doesn't work yet because the
test
          files are smaller than ID3_TYPE_FIND_MIN_SIZE.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email