[gstreamer-bugs] [Bug 404646] [audiofx] Compressor/Expander element

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=404646

  GStreamer | gst-plugins-good | Ver: HEAD CVS


Stefan Kost (gstreamer, gtkdoc dev) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84087|none                        |accepted-commit_now
               Flag|                            |




------- Comment #6 from Stefan Kost (gstreamer, gtkdoc dev)  2007-03-08 07:41 UTC -------
looks good. some nitpicks:

* Instead of (1 - filter->ratio) I would write (1.0 - filter->ratio) to show
that it is a float operation.

* what is 'zero' ? maybe a comment in the algorithm.

But basicaly, it can go in. Thanks for the hard work on this.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email