[gstreamer-bugs] [Bug 404646] [audiofx] Compressor/Expander element

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=404646

  GStreamer | gst-plugins-good | Ver: HEAD CVS


Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84087|accepted-commit_now         |committed
               Flag|                            |
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.6




------- Comment #7 from Sebastian Dröge  2007-03-08 10:04 UTC -------
Ok, thanks. I committed it with some small changes (+ docs integration and unit
test):

* Use 1.0 and 0.0 instead of 1 and 0 in the float cases
* Use doubles as intermediate values to prevent rounding errors
* Check in the beginning of each processing function if we actually have to do
something, this removes some FIXME because division by zero can't happen
anymore. One is still present though...
* Improve comments


2007-03-08  Sebastian Dröge  <slomo at circular-chaos.org>

        reviewed by: Stefan Kost  <ensonic at users.sf.net>

        * gst/audiofx/Makefile.am:
        * gst/audiofx/audiodynamic.c:
        (gst_audio_dynamic_characteristics_get_type),
        (gst_audio_dynamic_mode_get_type),
        (gst_audio_dynamic_set_process_function),
        (gst_audio_dynamic_base_init), (gst_audio_dynamic_class_init),
        (gst_audio_dynamic_init), (gst_audio_dynamic_set_property),
        (gst_audio_dynamic_get_property), (gst_audio_dynamic_setup),
        (gst_audio_dynamic_transform_hard_knee_compressor_int),
        (gst_audio_dynamic_transform_hard_knee_compressor_float),
        (gst_audio_dynamic_transform_soft_knee_compressor_int),
        (gst_audio_dynamic_transform_soft_knee_compressor_float),
        (gst_audio_dynamic_transform_hard_knee_expander_int),
        (gst_audio_dynamic_transform_hard_knee_expander_float),
        (gst_audio_dynamic_transform_soft_knee_expander_int),
        (gst_audio_dynamic_transform_soft_knee_expander_float),
        (gst_audio_dynamic_transform_ip):
        * gst/audiofx/audiodynamic.h:
        * gst/audiofx/audiofx.c: (plugin_init):
        Add new audiodynamic element which can act as a compressor or
        expander. Supported are hard-knee and soft-knee operation modes with
        user-specified ratio and threshold.
        Attack and release parameters are not yet implemented but will follow.
        * docs/plugins/Makefile.am:
        * docs/plugins/gst-plugins-good-plugins-docs.sgml:
        * docs/plugins/gst-plugins-good-plugins-sections.txt:
        * docs/plugins/gst-plugins-good-plugins.args:
        * docs/plugins/inspect/plugin-audiofx.xml:
        Integrate audiodynamic into the docs.
        * tests/check/Makefile.am:
        * tests/check/elements/audiodynamic.c: (setup_dynamic),
        (cleanup_dynamic), (GST_START_TEST), (dynamic_suite), (main):
        Add unit test for audiodynamic.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email