[gstreamer-bugs] [Bug 420079] New: [audioconvert] Uses biased rounding which results in distortions

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=420079

  GStreamer | gst-plugins-base | Ver: HEAD CVS

           Summary: [audioconvert] Uses biased rounding which results in
                    distortions
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: slomo at circular-chaos.org
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Hi,
audioconvert currently uses a biased rounding function, that will always round
to the smaller integer. The attached patch fixes this (with special care for
integer overflows) and results on one of my samples in ~3-5 db less noise.

Could someone please review the patch for sanity? :)

Bye


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email