[gstreamer-bugs] [Bug 421598] [wavpack] Add support for non-8*n depths and don't play audioconvert

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=421598

  GStreamer | gst-plugins-bad | Ver: HEAD CVS

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|421543                      |
  Attachment #85130|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.5




------- Comment #2 from Sebastian Dröge  2007-03-30 04:51 UTC -------
Ok, committed with a workaround for bug #421543...

2007-03-30  Sebastian Dröge  <slomo at circular-chaos.org>

        * ext/wavpack/gstwavpackdec.c: (gst_wavpack_dec_reset),
        (gst_wavpack_dec_init), (gst_wavpack_dec_sink_set_caps),
        (gst_wavpack_dec_clip_outgoing_buffer),
        (gst_wavpack_dec_post_tags), (gst_wavpack_dec_chain):
        * ext/wavpack/gstwavpackdec.h:
        * ext/wavpack/gstwavpackenc.c: (gst_wavpack_enc_reset),
        (gst_wavpack_enc_sink_set_caps), (gst_wavpack_enc_set_wp_config),
        (gst_wavpack_enc_chain):
        * ext/wavpack/gstwavpackenc.h:
        * ext/wavpack/gstwavpackparse.c:
        Don't play audioconvert. As wavpack wants/outputs all samples with
        width==32 and depth=[1,32] accept this and let audioconvert convert
        to accepted formats instead of doing it in the element for n*8 depths.
        This also adds support for non-n*8 depths and prevents some useless
        memory allocations. Fixes #421598
        Also add a workaround for bug #421542 in wavpackenc for now...
        * tests/check/elements/wavpackdec.c: (GST_START_TEST):
        * tests/check/elements/wavpackenc.c: (GST_START_TEST):
        * tests/check/elements/wavpackparse.c: (GST_START_TEST):
        Consider the change above in the unit tests and test if the correct
        caps are accepted and set. Also check for GST_BUFFER_OFFSET_END in
        the wavpackparse unit test.

        * ext/wavpack/gstwavpackdec.c: (gst_wavpack_dec_init),
        (gst_wavpack_dec_sink_set_caps):
        Set caps on the src pad as soon as possible.

        * ext/wavpack/gstwavpackdec.h:
        * ext/wavpack/gstwavpackcommon.h:
        * ext/wavpack/gstwavpackenc.h:
        * ext/wavpack/gstwavpackparse.h:
        Fix indention. gst-indent is now called by cicl.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=421598.