[gstreamer-bugs] [Bug 348085] [PLUGIN-MOVE] move spectrum to good

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=348085

  GStreamer | gst-plugins-bad | Ver: HEAD CVS




------- Comment #22 from Tim-Philipp Müller  2007-05-21 11:44 UTC -------
> There was one FIXME which now is fixed :)

Really? :)

  tpm at flap:~/gst-plugins-bad/gst/spectrum$ grep -iHn FIXME *c
  fix_fft.c:274:  fixed *pa = hpa;              /* FIXME */
  gstspectrum.c:240:      /* FIXME, this will segfault when the transform
function  is running */
  gstspectrum.c:400:  /* FIXME: 4.0 was 2.0 before, but that include the
mirrored spectrum */

At least the second one looks like it needs fixing given that there's not a
single LOCK being taken anywhere in the file.


Also, there should be a simple unit test in tests/check/elements/ IMHO, so that
at least the basic code paths get run through valgrind on a regular basis and
are checked for leaks etc.

Small nitpick: should ->len and ->base maybe be turned into #defines given that
they aren't configurable or changed anywhere?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=348085.