[gstreamer-bugs] [Bug 420206] Collectpads causes a segv. when stopping after a pad remove

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=420206

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Wim Taymans changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wim at fluendo.com




------- Comment #9 from Wim Taymans  2007-05-24 11:44 UTC -------
I can't remember exactly. I do remember that we need two lists (or one with a
marker, maybe?) because we cannot simply modify the list when removing a pad
while potentially collect is running over the list. We cannot protect the list
with a lock because collect might block (when pushing to a prerolled sink) so
that the pad removal will also block.

So currently, there is one master list (pad_list). Right before calling
collect, all of pad_list is copied to ->data and then collect is supposed to
operate on ->data. Removing pads while collect is running should not touch this
list, hence the check. I think some code used to iterate ->data to see which
pads were in the collection.




-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=420206.