[gstreamer-bugs] [Bug 492077] Build issues on Windows/MSVC

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=492077

  GStreamer | gstreamer (core) | Ver: 0.10.14

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98238|0                           |1
        is obsolete|                            |
  Attachment #98238|reviewed                    |obsolete
               Flag|                            |
         AssignedTo|t.i.m at zen.co.uk             |gstreamer-
                   |                            |bugs at lists.sourceforge.net
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #8 from Tim-Philipp Müller  2007-11-01 23:52 UTC -------
After further discussion on IRC:

Nov 01 17:52:45 <__tim> oleavr: can I bug you again about the export
declaration for a second?
Nov 01 17:54:20 <__tim> oleavr: why does it need to be exported at all? 
exported debug category in plugins usually just means that other .c files
within the same plugin should be able to use the symbol, but it doesn't need to
be visible to code outside the plugin afaics
Nov 01 17:55:12 <oleavr> __tim: ahh.. that explain a few things, I was
wondering what the dllimport was doing there in the first place
Nov 01 17:56:16 <oleavr> __tim: let me try removing it here and see if MSVC
goes on a pony killing spree :)

Nov 01 19:49:00 <oleavr> __tim: I'm puzzled about the whole
__declspec(dllimport) for the GST_DEBUG_CATEGORY_EXTERN, can't see why it was
there in the first place, it should clearly be extern for all cases.. and I
just verified this with MSVC, builds just fine without any warnings
Nov 01 19:50:44 <oleavr> __tim: so it'd rock if you could fix it by removing
the MSVC special-casing and mark the remaining patch on #492077 as obsolete :)

Nov 01 19:56:34 <__tim> oleavr: okay, I'll have another look later; maybe
there's a hint in the history why it was added in the first place :)

Nov 01 20:24:49 <oleavr>__tim: tracked it down:


http://webcvs.freedesktop.org/gstreamer/gst-plugins-good/gst/avi/gstavidemux.c?r1=1.181&r2=1.182

http://webcvs.freedesktop.org/gstreamer/gst-plugins-good/gst/avi/gstavidemux.c?r1=1.186&r2=1.187

http://webcvs.freedesktop.org/gstreamer/gstreamer/gst/gstinfo.h?r1=1.94&r2=1.95

http://webcvs.freedesktop.org/gstreamer/gstreamer/gst/gstinfo.h?r1=1.99&r2=1.100

http://webcvs.freedesktop.org/gstreamer/gstreamer/gst/gstinfo.h?r1=1.100&r2=1.101

looks to me like the initial fix couldn't possibly have been tested given that
it has a syntax error (_declspec instead of __declspec)
Nov 01 20:26:22 <__tim> oh THAT's where it comes from, it was just
copy'n'pasted from a plugin
Nov 01 20:26:25 <__tim> excellent

 2007-11-01  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/gstinfo.h: (GST_DEBUG_CATEGORY_EXTERN):
          Remove __declspec(dllimport) for MSVC that was copied over into core
          from a plugin, obviously without ever having been tested (note the
          single underscore in _declspec in the initial commit), and that
          doesn't really make sense.  See #492077.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=492077.