[gstreamer-bugs] [Bug 493983] Build issues on Windows

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=493983

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98598|none                        |committed
               Flag|                            |
  Attachment #98603|none                        |committed
               Flag|                            |
  Attachment #98605|none                        |committed
               Flag|                            |
  Attachment #98606|none                        |committed
               Flag|                            |
  Attachment #98607|none                        |committed
               Flag|                            |
  Attachment #98608|none                        |committed
               Flag|                            |
         AssignedTo|t.i.m at zen.co.uk             |gstreamer-
                   |                            |bugs at lists.sourceforge.net
             Status|ASSIGNED                    |RESOLVED
         OS/Version|Windows                     |All
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.15




------- Comment #9 from Tim-Philipp Müller  2007-11-06 15:18 UTC -------
Thanks, all committed:

2007-11-06  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/gst.c: (_gst_disable_segtrap):
          Make  _gst_disable_segtrap static, it's only used in gstplugin.c and
          we can use gst_segtrap_is_enabled() there now that we have that API.
          Move _gst_debug_dump_dot_dir into gstdebugutils.c, there's no reason
          to do the getenv here (and export the variable).

        * gst/gstdebugutils.c: (debug_dump_element),
          (_gst_debug_bin_to_dot_file), (_gst_debug_bin_to_dot_file_with_ts):
          Don't use VLAs which is a C99ism and throws off MSVC (#493983).

        * gst/gstinfo.c: (_priv_gst_info_start_time), (_gst_debug_init),
          (gst_debug_log_default):
          Rename _gst_info_start_time to priv_gst_info_start_time so it
          doesn't get exported (was never in any header).

        * gst/gstplugin.c: (_gst_plugin_fault_handler_setup),
          (gst_plugin_loading_mutex):
          Make static mutex gst_plugin_loading_mutex really static (was never
          in any header), and use gst_segtrap_is_enabled() instead of
          _gst_disable_segtrap.

        * gst/gsttrace.c: (_gst_trace_default):
          Make local _gst_trace_default static (was never in any header).

2007-11-06  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Ole André Vadla Ravnås  <ole.andre.ravnas at tandberg.com>

        * win32/common/libgstbase.def:
        * win32/common/libgstcontroller.def:
        * win32/common/libgstdataprotocol.def:
        * win32/common/libgstnet.def:
        * win32/common/libgstreamer.def:
          Add more missing symbols, remove some duplicates, and sort
          as the 'sort' command sorts it (partially fixes #493983).


I've removed some symbols (which I've made static now) and these which are
private:

libgstreamer.def:
        _gst_buffer_initialize
        _gst_event_initialize
        _gst_format_initialize
        _gst_message_initialize
        _gst_plugin_initialize
        _gst_query_initialize
        _gst_tag_initialize
        _gst_value_initialize
        _gst_debug_init

        _gst_parse_launch

        __gst_in_valgrind

        __gst_element_details_clear
        __gst_element_details_copy
        __gst_element_details_set   <-------- FIXME: make static

        __gst_element_factory_add_interface           [in headers, but used
only internally by the registry]
        __gst_element_factory_add_static_pad_template [in headers, but used
only internally by the registry]

        gst_proxy_pad_do_query_type
        gst_proxy_pad_get_type
        gst_type_find_debug

libgstcontroller.def:
        __gst_controller_key
        gst_controller_debug


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=493983.