[gstreamer-bugs] [Bug 496761] New: [PATCH] RTSP message leaks memory when uninitialized

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=496761

  GStreamer | gst-plugins-base | Ver: HEAD CVS
           Summary: [PATCH] RTSP message leaks memory when uninitialized
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: ext-tommi.myohanen at nokia.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


==16700== 6,312 (3,031 direct, 3,281 indirect) bytes in 83 blocks are
definitely lost in loss record 23 of 30
==16700==    at 0x4020626: malloc (vg_replace_malloc.c:149)
==16700==    by 0x4280E9C: g_malloc (in
/targets/OSSO_1.1_X86/usr/lib/libglib-2.0.so.0.1200.12)
==16700==    by 0x4292428: g_strdup (in
/targets/OSSO_1.1_X86/usr/lib/libglib-2.0.so.0.1200.12)
==16700==    by 0x4A59419: gst_rtsp_message_add_header (gstrtspmessage.c:507)
==16700==    by 0x4A56D49: parse_line (gstrtspconnection.c:778)
==16700==    by 0x4A57417: gst_rtsp_connection_receive
(gstrtspconnection.c:1054)
==16700==    by 0x4A2D584: gst_rtspsrc_connection_receive (gstrtspsrc.c:1194)
==16700==    by 0x4A2EF12: gst_rtspsrc_send (gstrtspsrc.c:3038)
==16700==    by 0x4A308CF: gst_rtspsrc_pause (gstrtspsrc.c:4325)
==16700==    by 0x4A39490: gst_rtspsrc_change_state (gstrtspsrc.c:4504)
==16700==    by 0x4058DDF: gst_element_change_state (gstelement.c:2362)
==16700==    by 0x4059475: gst_element_set_state_func (gstelement.c:2312)

This happens because only the header array is deleted - not the contents. Each
RTSPKeyValue contains a g_strdup'ed value field that needs to be freed too. 

Attached patch fixes this leak.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=496761.