[gstreamer-bugs] [Bug 358841] [dv1394src] should have property probe

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=358841

  GStreamer | gst-plugins-good | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
  Attachment #87468|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.7




------- Comment #24 from Tim-Philipp Müller  2007-11-14 19:14 UTC -------
Committed with small changes:

 2007-11-14  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Julien Puydt <julien dot puydt at laposte net>

        * ext/raw1394/Makefile.am:
        * ext/raw1394/gst1394probe.c: (gst_1394_get_guid_array),
          (gst_1394_property_probe_get_properties),
          (gst_1394_property_probe_probe_property),
          (gst_1394_property_probe_needs_probe),
          (gst_1394_property_probe_get_values),
          (gst_1394_property_probe_interface_init),
          (gst_1394_type_add_property_probe_interface):
        * ext/raw1394/gst1394probe.h: (GST_1394_PROBE_H):
        * ext/raw1394/gstdv1394src.c: (_do_init), (gst_dv1394src_class_init),
          (gst_dv1394src_init), (gst_dv1394src_dispose),
          (gst_dv1394src_set_property), (gst_dv1394src_get_property),
          (gst_dv1394src_discover_avc_node), (gst_dv1394src_query),
          (gst_dv1394src_update_device_name):
        * ext/raw1394/gstdv1394src.h:
          Implement GstPropertyProbe interface and add "device-name" property,
          so applications can use this to probe for available devices in the
          same way they can already with v4lsrc and v4l2src (however horrible
          this property probe interface may be). Fixes #358841.

(renamed new files to make the filename slighty shorter; renamed
_find_device_name() to _update_device_name(); added rom1394_free_directory() in
update_device_name() and some additional checks/logging; removed FIXME in
gst_dv1394src_discover_avc_node() - calling update_device_name() shouldn't be
necessary there, because that branch is executed only if a GUID has been set
explicitly, at which point the name would already have been updated via the
set_property function).

Please test version in CVS to make sure I didn't mess anything up.

Thanks a lot for the patch, and sorry for the long wait.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=358841.