[gstreamer-bugs] [Bug 396779] Preset interface for elements

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=396779

  GStreamer | gst-plugins-base | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk




------- Comment #24 from Tim-Philipp Müller  2007-11-19 12:09 UTC -------
> It seems the feature is badly understood. I'll try to explain further.

This may be so, but it should still have been reviewed before your commit in
any case.  It is your responsibility to poke people to review it and understand
it and see the usefulness of it before you commit it.


> The implementation was available for almost a year and I announced it on the
> mailing list and irc. Noone objected.

"No one objected" does not mean "ok to commit", as I (and others) have pointed
out to you on IRC in the past (in relation to this bug, even!).

And while you say 'has been available over a year', an actual patch against
core has been available for less than a month (and incidentally most people
were busy releasing core/base, which is a fair bit of work, so your patch
received even less attention than it would have received otherwise).

Again, it is your responsibility to poke people to review things.  I know that
it can be frustrating and discouraging from own experience, but that's not an
excuse to just commit stuff IMHO.


> There are some todos which need discussion, but a new core lifecycle
> just started, so lets discuss and I will make the changes. 

Does this have a name yet? If not, I shall call it the
"guerilla-I-committed-it-deal-with-it-now-or-suck-it-up tactic" ;)


More on topic: while I don't have time to look into the entire thing right now,
just looking at the API I think I'd prefer gst_preset_get_preset_names() to
return a NULL-terminated gchar ** - the ownership and type and free-ing of this
is much easier than with a GList (e.g. what's in the GList? Strings? Does the
GList contain strdup'ed strings or not?) (I know other interfaces return a
GList, but I don't think that's a good reason to keep doing it - and bindings
have to special-case this anyway).


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=396779.