[gstreamer-bugs] [Bug 475723] cleanup static caps correctly

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=475723

  GStreamer | gstreamer (core) | Ver: HEAD CVS




------- Comment #5 from Stefan Kost (gstreamer, gtkdoc dev)  2007-09-11 13:58 UTC -------
if you look at gstcaps.c::gst_static_caps_get()
* the alternative/addition to g_atomic_int_{s,g}et() would be to
  G_LOCK (static_caps_lock);
* yes, the > 0 check should be a == 1
* the releasing of the memory is correct, as its dynamiclly allocated. we are
not releasing the caps memory, but the one of the structure.

* as the dirty details of how gst_static_caps_get() works is in gstcaps.c the
function that releases them can be put there too. But then also
gst_static_caps_get() should be in gststaticcaps.c. So what about

gstelementfactory.c::gst_element_factory_cleanup() calling
gstpadtemplate.c::__gst_static_pad_template_clear() and this calling
gstcaps.c::__gst_static_caps_clear()


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=475723.