[gstreamer-bugs] [Bug 459862] typefinding coud be more efficient

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=459862

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92274|0                           |1
        is obsolete|                            |




------- Comment #6 from Tim-Philipp Müller  2007-09-25 12:26 UTC -------
Created an attachment (id=96164)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=96164&action=view)
same as above, but a bit more terse and with more comments (some temporary)

I actually did look at this again a while ago, but then couldn't comment
because bugzilla was down.  Attached is what I came up with.  It's basically
the same as your patch, just a bit more terse and with a few extra comments
here and there.

My main question is basically: wouldn't it be better/more efficient to sort the
list by offset+size rather than just offset?  Otherwise we might stop looking
for cached content in the list too early, no?

As for caching the list of typefinders: it would probably be best to file a
separate enhancement bug for this.  It looks like an okay thing to do in
general, but it probably needs some more work to take into account registry
rescans (and locking ?) and freeing resources on gst_deinit() IMO.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=459862.