[gstreamer-bugs] [Bug 525743] support for subtitles as kate streams

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=525743

  GStreamer | gst-plugins-bad | Ver: 0.10.x

ogg.k.ogg.k changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ogg.k.ogg.k at googlemail.com




------- Comment #3 from ogg.k.ogg.k  2008-04-03 11:13 UTC -------
There is second patch, but I'm hitting a bugzilla internal error each time
I try to submit it (reported to bugmaster). It's very small though, so here
it is.

Muxed streams (using oggmux from -base) need the second hunk to be correct.
Reading the code, I think the increase of the pageno is wrong as it is ++'d
afterwards at the ogg_stream_flush, but I'm not confident this is right.

I've tried muxing a theora stream and a vorbis stream as well with this patch
in, and oggz-validate (checks ogg streams for errors) is happy with them.
Would be nice to have someone who groks oggmux well to have a look at it to
see if I'm not missing anything there.

The first hunk just allows oggmux to accept application/x-kate on its sink
and is needed for the kate parser to be able to be piped to oggmux,

diff -ru /tmp/gst-ogg/gstoggmux.c gst-plugins-base-0.10.17/ext/ogg/gstoggmux.c
--- /tmp/gst-ogg/gstoggmux.c    2008-04-02 19:53:47.000000000 +0100
+++ gst-plugins-base-0.10.17/ext/ogg/gstoggmux.c    2008-04-02
21:47:18.000000000 +0100
@@ -89,7 +183,8 @@
     GST_STATIC_CAPS ("video/x-theora; "
         "audio/x-vorbis; audio/x-flac; audio/x-speex; "
         "application/x-ogm-video; application/x-ogm-audio; video/x-dirac; "
-        "video/x-smoke; text/x-cmml, encoded = (boolean) TRUE")
+        "video/x-smoke; text/x-cmml, encoded = (boolean) TRUE; "
+        "application/x-kate")
     );

 static void gst_ogg_mux_base_init (gpointer g_class);
@@ -1253,7 +1346,7 @@
     if (GST_BUFFER_IS_DISCONT (buf)) {
       packet.packetno++;
       /* No public API for this; hack things in */
-      pad->stream.pageno++;
+      //pad->stream.pageno++;
       force_flush = TRUE;
     }


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=525743.