[gstreamer-bugs] [Bug 526814] Add disconnect notify to gst_pad_add_{data, event, buffer}_probe() functions

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=526814

  GStreamer | gstreamer (core) | Ver: HEAD CVS

José Alburquerque changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |UNCONFIRMED




------- Comment #3 from José Alburquerque  2008-04-07 23:03 UTC -------
(In reply to comment #2)
> This makes sense to have, I guess. IIRC the python bindings had the same issue,
> but just implemented those functions themselves (everything required is
> accessible via public functions, after all).
> 
> As for the patch:
> 
> Why do you use G_CONNECT_AFTER for g_signal_connect_data()?
> 
> And why special-case the if (disconnect_notify) case rather than using
> g_signal_connect_data for both cases?
> 

You're right.  It is possible to use g_signal_connect_data for both cases.  The
G_CONNECT_AFTER I wasn't sure about, it just seemed like g_signal_connect_data
required something for connect_flags and G_CONNECT_SWAPPED did not seem right. 
If the flags are not required, the patch can be modified (I'd do it).

As for the patch, if gst-python implemented these methods themselves, maybe we
can also.  Would you want a fixed patch anyway?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=526814.