[gstreamer-bugs] [Bug 526814] Add disconnect notify to gst_pad_add_{data, event, buffer}_probe() functions

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=526814

  GStreamer | gstreamer (core) | Ver: HEAD CVS




------- Comment #8 from Tim-Philipp Müller  2008-04-09 20:45 UTC -------
> The GClosureNotify is used so that when the probe is removed (the signal is
> disconnected), a callback is invoked in which case we can then remove the extra
> data.  Does that make sense?

Of course.

> The problem, I think, is that a GDestroyNotify does not notify when signals are
> disconnected.

It would in this case. It would be the exact same thing, the question is just
what the notify callback is supposed to look like (GDestroyNotify only has one
argument, namely the data argument, while GClosureNotify has two, namely the
data argument and a GClosure argument). I guess this is a bit hacky and C-ish,
I just think exposing a GClosureNotify might be confusing, that's all. I'll ask
some other people for opinions.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=526814.