[gstreamer-bugs] [Bug 520892] [dshowvideosrc] latency and shutdown improvements

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=520892

  GStreamer | gst-plugins-bad | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
 Attachment #106740|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
            Summary|dshowvideosrc latency and   |[dshowvideosrc] latency and
                   |shutdown improvements       |shutdown improvements
   Target Milestone|HEAD                        |0.10.7




------- Comment #4 from Tim-Philipp Müller  2008-04-11 19:35 UTC -------
Committed, thanks:

 2008-04-11  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Ole André Vadla Ravnås  <ole.andre.ravnas at tandberg com>

        * sys/dshowsrcwrapper/gstdshowvideosrc.c: (PROP_DEVICE_NAME),
          (gst_dshowvideosrc_class_init), (gst_dshowvideosrc_init),
          (gst_dshowvideosrc_dispose), (gst_dshowvideosrc_stop),
          (gst_dshowvideosrc_unlock), (gst_dshowvideosrc_unlock_stop),
          (gst_dshowvideosrc_create), (gst_dshowvideosrc_push_buffer):
        * sys/dshowsrcwrapper/gstdshowvideosrc.h:
          Don't increase latency by queuing buffers in an async queue when
          the streaming thread can't keep up or isn't scheduled often
          enough for some other reason, but just drop the previous buffer
          in that case. Also implement GstBaseSrc::unlock for faster
          unlocking when shutting down. (#520892).


FWIW, the GST_CAT_{LOG|DEBUG|ERROR|*} statements could use a bit of cleaning up
- the _CAT part and argument is not required at all, the

 #define GST_CAT_DEFAULT dshowvideosrc_debug

takes care of that already.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=520892.