[gstreamer-bugs] [Bug 529488] [sidplay] Missing sentinel in function call

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=529488

  GStreamer | gst-plugins-ugly | Ver: HEAD CVS

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.8




------- Comment #1 from Sebastian Dröge  2008-04-25 23:10 UTC -------
Hm, the g++ docs suggest that you can't use NULL as a sentinel in C++:

-Wstrict-null-sentinel (C++ only)
    Warn also about the use of an uncasted NULL as sentinel. When compiling
only
    with GCC this is a valid sentinel, as NULL is defined to __null.
    Although it is a null pointer constant not a null pointer, it is guaranteed
    to of the same size as a pointer. But this use is not portable across
    different compilers.

2008-04-26  Sebastian Dröge  <slomo at circular-chaos.org>

        * ext/sidplay/gstsiddec.cc:
        Cast NULL sentinels to void * as NULL is defined as an integer
        constant in most environments when using C++ and it's size might
        be different from a pointer. Fixes #529488.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=529488.