[gstreamer-bugs] [Bug 530531] [typefinding] bad read in mpeg_video_stream_type_find

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=530531

  GStreamer | gst-plugins-base | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|t.i.m at zen.co.uk             |gstreamer-
                   |                            |bugs at lists.sourceforge.net
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.20




------- Comment #3 from Tim-Philipp Müller  2008-04-30 14:42 UTC -------
I think the minimal fix is to just remove the

        if (data[3] == 0xB3)
          continue;

where the bad read happens; it doesn't look like it's meant to be there and
only a small optimisation anyway as far as I can tell.


However, I couldn't help myself and did a bit more (in preparation of fixing
this function a bit more - it doesn't seem to recognise everything it should):

 2008-04-30  Tim-Philipp Müller  <tim.muller at collabora co uk>

        * gst/typefind/gsttypefindfunctions.c: (MpegVideoStreamCtx),
          (mpeg_video_stream_ctx_advance), (mpeg_video_stream_ctx_ensure_data),
          (mpeg_video_stream_type_find):
          Refactor a bit: use context structure to track parsing offset and
size of
          available data and make the code a bit clearer. Fixes bad memory
access
          in #356937.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=530531.