[gstreamer-bugs] [Bug 545197] jackaudiosrc

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=545197

  GStreamer | gst-plugins-bad | Ver: HEAD CVS

Stefan Kost (gstreamer, gtkdoc dev) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115858|none                        |needs-work
               Flag|                            |




------- Comment #11 from Stefan Kost (gstreamer, gtkdoc dev)  2008-08-06 06:09 UTC -------
much better!

had to cd to 'ext' before appying 
cd ext/
patch --dry-run -p0 <../jacksrc-02.diff
btw. meld (meld.sf.net) is a good tool to graphicaly review the changes.

* gstjack.c
  - still changes things for GST_PLUGIN_DEFINE
* gstjackaudiosink.c
  - there's some unwanted change too:
    -gst_jack_ring_buffer_get_type (void)
    +gst_jack_ring_buffer_get_type()
  - there is a #if 0 ... #endif - if its moved elsewhere, please remove
* gstjackaudiosink.h
  - there's some unwanted change too:
    -GType gst_jack_audio_sink_get_type (void);
    +GType gst_jack_audio_sink_get_type ();
* jack/gstjackringbuffer.h
  so this is now the same api, but different implementation in src/sink?
  it would also be an option to add this stuff to gstjack.h then.
  what do you think?

I hope thats the last round. thanks for the good work on this.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=545197.