[gstreamer-bugs] [Bug 547075] New: [speex] Encoder doesn't handle non-zero start timestamps and discontinuities properly

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=547075

  GStreamer | gst-plugins-good | Ver: HEAD CVS
           Summary: [speex] Encoder doesn't handle non-zero start timestamps
                    and discontinuities properly
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: slomo at circular-chaos.org
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Hi,
the speex encoder (and also the celt encoder which is more or less the same
code) doesn't handle non-zero start timestamps and discontinuities properly. It
simply starts to count at 0 and ignores all upstream timestamps.

This can lead to a/v synchronization issues when muxing together with video.

The fix for this is probably to a) get the start timestamp and offset all
timestamps and granulepos with that and b) if a discontinuity is detected
encode everything in the GstAdapter (if necessary add some silence) and then
continue to encode the discont buffer and all following with the new
timestamps.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=547075.