[gstreamer-bugs] [Bug 563133] New: oggmux outputs a broken ogg when input contains discont buffers

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=563133

  GStreamer | gst-plugins-base | Ver: HEAD CVS
           Summary: oggmux outputs a broken ogg when input contains discont
                    buffers
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: alessandro.d at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Since
http://webcvs.freedesktop.org/gstreamer/gst-plugins-base/ext/theora/theoraenc.c?r1=1.67&r2=1.68
has been applied, recording an ogg with
pitivi produces a broken file.
The problem seems to be here
http://webcvs.freedesktop.org/gstreamer/gst-plugins-base/ext/ogg/gstoggmux.c?view=diff&r1=1.85&r2=1.86

changing the code from:

  if (GST_BUFFER_IS_DISCONT (buf)) {
    packet.packetno++;
    /* No public API for this; hack things in */
    pad->stream.pageno++;
    force_flush = TRUE;
  }

to:

  if (GST_BUFFER_IS_DISCONT (buf))
    force_flush = TRUE;

fixes the bug. It's not clear to me why oggmux is incrementing packetno
and pageno there. 

It also works if I revert the theoraenc change, as the if is never executed.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=563133.