[gstreamer-bugs] [Bug 510982] gst_tag_demux_trim_buffer: invalid return value

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=510982

  GStreamer | gst-plugins-base | Ver: HEAD CVS




------- Comment #9 from Tim-Philipp Müller  2008-02-07 20:49 UTC -------
I told him on IRC to set the blocker flag, so that's on me.

I haven't committed this yet for two reasons:

 - I think the patch may not be correct in its current form:
   in pull mode, this situation should never happen, unless
   there's an integer overflow (which should be caught at the
   right spot then and not here); in push mode, the TRUE
   return + NULL buffer is used to signal 'need more data',
   during typefinding, so returning FALSE would break things
   if buffers come in in certain chunkings. (Note: this is
   all from memory, I looked at it a while back)

 - it's not obvious to me we still need to handle this seeing
   that it's caught elsewhere.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=510982.