[gstreamer-bugs] [Bug 515701] [smoke] Several valgrind warnings exposed by unit test

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=515701

  GStreamer | gst-plugins-good | Ver: HEAD CVS

Jan Schmidt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thaytan at mad.scientist.com




------- Comment #2 from Jan Schmidt  2008-02-11 13:50 UTC -------
if by 'false warning in valgrind' you mean it warns that encsize is used
uninitialised, valgrind usually knows best there :)

It looks like this line:

smokecodec_encode (smokeenc->info, data, flags, outdata, &encsize);

is passing encsize uninitialised, where I think it should be initialised to
outsize just before - it looks like you pass in the allocated size of the
output buffer, and it passes back the amount that was used.

That's a wasteful way to do it, of course - a pattern like that lead to massive
memory use in the ffmpeg decoder because it massively over-supplied the
allocated output buffer for each encode call.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=515701.