[gstreamer-bugs] [Bug 515905] New: gst-error.m4 needs no%E_MACRO_REDEFINED on Solaris

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=515905

  GStreamer | gst-plugins-good | Ver: HEAD CVS
           Summary: gst-error.m4 needs no%E_MACRO_REDEFINED on Solaris
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: mooney at dogbert.cc.ndsu.nodak.edu
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Please describe the problem:
When building with the latest Sun development environment (Workshop 12), the
build fails because it's using -errwarn, and no%E_MACRO_REDEFINED is not
included in the -errwarn list.

Whenever gst-libs/gst/gettext.h is included, each of the gettext-related
functions results in a "macro redefined" warning, which becomes an error
because of the -errwarn flag:

/bin/bash ../../libtool --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I.
-I../..   -I/local/include/X11 -I/local/include -I/local/gnu/include/X11
-I/local/gnu/include -I../../gst-libs -D_REENTRANT -D_PTHREADS
-I/local/gnu/include/gstreamer-0.10
 -I/local/gnu/include/glib-2.0 -I/local/gnu/lib/64/glib-2.0/include
-I/local/gnu/include/libxml2   -D_REENTRANT -D_PTHREADS
-I/local/gnu/include/gstreamer-0.10 -I/local/gnu/include/glib-2.0
-I/local/gnu/lib/64/glib-2.0/include -I/local/gnu/include/libxml2  
-I../../gst-libs -I../../gst-libs -D_REENTRANT -D_PTHREADS
-I/local/gnu/include/gstreamer-0.10 -I/local/gnu/include/glib-2.0
-I/local/gnu/lib/64/glib-2.0/include -I/local/gnu/include/libxml2  
-errwarn=%all,no%E_EMPTY_DECLARATION,no%E_STATEMENT_NOT_REACHED,no%E_ARGUEMENT_MISMATCH
-g    -I/local/include/X11 -I/local/include -I/local/gnu/include/X11
-I/local/gnu/include -Xa -xO2 -xstrconst -errtags=yes -KPIC -m64
-xtarget=native -xarch=native -c -o libgstapetag_la-gstapedemux.lo `test -f
'gstapedemux.c' || echo './'`gstapedemux.c
mkdir .libs
 cc -DHAVE_CONFIG_H -I. -I../.. -I/local/include/X11 -I/local/include
-I/local/gnu/include/X11 -I/local/gnu/include -I../../gst-libs -D_REENTRANT
-D_PTHREADS -I/local/gnu/include/gstreamer-0.10 -I/local/gnu/include/glib-2.0
-I/local/gnu/lib/64/glib-2.0/include -I/local/gnu/include/libxml2 -D_REENTRANT
-D_PTHREADS -I/local/gnu/include/gstreamer-0.10 -I/local/gnu/include/glib-2.0
-I/local/gnu/lib/64/glib-2.0/include -I/local/gnu/include/libxml2
-I../../gst-libs -I../../gst-libs -D_REENTRANT -D_PTHREADS
-I/local/gnu/include/gstreamer-0.10 -I/local/gnu/include/glib-2.0
-I/local/gnu/lib/64/glib-2.0/include -I/local/gnu/include/libxml2
-errwarn=%all,no%E_EMPTY_DECLARATION,no%E_STATEMENT_NOT_REACHED,no%E_ARGUEMENT_MISMATCH
-g -I/local/include/X11 -I/local/include -I/local/gnu/include/X11
-I/local/gnu/include -Xa -xO2 -xstrconst 
-errtags=yes -KPIC -m64 -xtarget=native -xarch=native -c gstapedemux.c  -KPIC
-DPIC -o .libs/libgstapetag_la-gstapedemux.o
"../../gst-libs/gst/gettext.h", line 45: warning: macro redefined: gettext
(E_MACRO_REDEFINED)
"../../gst-libs/gst/gettext.h", line 46: warning: macro redefined: dgettext
(E_MACRO_REDEFINED)
"../../gst-libs/gst/gettext.h", line 47: warning: macro redefined: dcgettext
(E_MACRO_REDEFINED)
"../../gst-libs/gst/gettext.h", line 48: warning: macro redefined: ngettext
(E_MACRO_REDEFINED)
"../../gst-libs/gst/gettext.h", line 50: warning: macro redefined: dngettext
(E_MACRO_REDEFINED)
"../../gst-libs/gst/gettext.h", line 52: warning: macro redefined: dcngettext
(E_MACRO_REDEFINED)
"../../gst-libs/gst/gettext.h", line 54: warning: macro redefined: textdomain
(E_MACRO_REDEFINED)
"../../gst-libs/gst/gettext.h", line 55: warning: macro redefined:
bindtextdomain (E_MACRO_REDEFINED)
"../../gst-libs/gst/gettext.h", line 56: warning: macro redefined:
bind_textdomain_codeset (E_MACRO_REDEFINED)
"gstapedemux.c", line 87: warning: syntax error:  empty declaration
(E_EMPTY_DECLARATION)


The best fix would probably be to fix up gst/gettext.h, but I went with the
easy fix first -- just add no%E_MACRO_REDEFINED to -errwarn.

Patch is attached.

Steps to reproduce:
Build on Solaris 10 with Workshop 12

Actual results:
build fails

Expected results:
build succeeds

Does this happen every time?
yes

Other information:


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=515905.