[gstreamer-bugs] [Bug 516395] gst_buffer_create_sub does not copy flags

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=516395

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
 Attachment #105215|none                        |reviewed
               Flag|                            |




------- Comment #3 from Tim-Philipp Müller  2008-02-14 17:24 UTC -------
(I started typing this before Wim's comment, but since it's more detailed I
might just as well post it anyway)

The only flag that looks like it should be copied for sure is the GAP flag IMO.

- READONLY: not sure, could be copied I guess, although it shouldn't really 
  be necessary since sub-buffers are never writable (I think)

- PREROLL: not used, is it?

- DISCONT shouldn't be copied, I think (unless offset is 0 maybe)

- IN_CAPS: shouldn't be copied (which you seem to agree with)

- GAP: should be copied (as you do).

- DELTA_UNIT: not sure about this one, I think the semantics are only really
clear for the normal case where one would only look at the buffer as a whole
(so probably shouldn't be copied)


I think it would be best to just copy the flags we know make sense to copy,
rather than just copy all flags unconditionally (even unknown ones of
subclasses, which we don't know much about).


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=516395.