[gstreamer-bugs] [Bug 516395] gst_buffer_create_sub does not copy flags

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Thu Feb 14 09:39:40 PST 2008


If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=516395

  GStreamer | gstreamer (core) | Ver: HEAD CVS




------- Comment #5 from Wim Taymans  2008-02-14 17:39 UTC -------
READONLY is set in _init, so you can't overwrite this flag.

IN_CAPS should be cleared.

You can't decide on DISCONT. Take this example:

1 parent buffer of size 100 with DISCONT flag
  - create sub 0, 50    -> copy DISCONT
  - create sub 50, 100  -> ? 

You can't copy the discont flag on the second buffer, because if you send the
first subbufer downstream, it's not DISCONT with that buffer. If you however
drop the first subbuffer, then the DISCONT flag should be on the second buffer.

DELTA_UNIT refers to the first byte in the buffer, it's possible that a
subbuffer starts on a keyunit fine so you can't blindly copy the DELTA_UNIT
flag.

I would start with a patch that keeps the GAP and (possibly) the PREROLL flag
of the parent buffer for now. If we find a good case for copying the others
we'll add it but I would not do this right now.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=516395.




More information about the Gstreamer-bugs mailing list