[gstreamer-bugs] [Bug 516649] New: v4l2src tries to VIDIOC_S_PARM without checking capabilities

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=516649

  GStreamer | gst-plugins-good | Ver: HEAD CVS
           Summary: v4l2src tries to VIDIOC_S_PARM without checking
                    capabilities
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: sjoerd at luon.net
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


In v4l2src_calls.c:gst_v4l2src_set_capture VIDIOC_S_PARM always get used with a
update timeperframe field. That is as long as the G_PARM ioctl succeeds. 

Now according to the v4l2spec this field is only supported when the driver has
V4L2_CAP_TIMEPERFRAME in its capabilities field. Both my bttv card and my pwc
webcam don't have this so they always give an (unneeded error)

I'll attach a patch to check for this capability before doing {G,S}_PARM


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=516649.