[gstreamer-bugs] [Bug 517985] New: compile error with gstlame.c on Solaris

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=517985

  GStreamer | gst-plugins-ugly | Ver: 0.10.17
           Summary: compile error with gstlame.c on Solaris
           Product: GStreamer
           Version: 0.10.17
          Platform: Other
        OS/Version: Solaris
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-ugly
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: mooney at dogbert.cc.ndsu.nodak.edu
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


I'm building gst-plugins-ugly 0.10.7 to go along with gstreamer 0.10.17,
gst-plugins-base 0.10.17, and gst-plugins-good from CVS.  I'm building on
x86_64-sun-solaris2.10 with the Sun Workshop 12 compilers.

When I get to the build for ext/gstlame.c, it fails with this error:

source='gstlame.c' object='libgstlame_la-gstlame.lo' libtool=yes \
DEPDIR=.deps depmode=none /bin/bash ../../depcomp \
/bin/bash ../../libtool --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I.
-I../..   -I/local/include/X11 -I/local/include -I/local/gnu/include/X11
-I/local/gnu/include -I../../gst-libs -I../../gst-libs -D_REENTRANT -D_PTHREADS
-I/local/gnu/include/gstreamer-0.10 -I/local/gnu/include/glib-2.0
-I/local/gnu/lib/64/glib-2.0/include -I/local/gnu/include/libxml2     -g   
-DGSTLAME_PRESET -I/local/include/X11 -I/local/include -I/local/gnu/include/X11
-I/local/gnu/include -Xa -xO2 -xstrconst -KPIC -m64 -xtarget=native
-xarch=native -c -o libgstlame_la-gstlame.lo `test -f 'gstlame.c' || echo
'./'`gstlame.c
mkdir .libs
 cc -DHAVE_CONFIG_H -I. -I../.. -I/local/include/X11 -I/local/include
-I/local/gnu/include/X11 -I/local/gnu/include -I../../gst-libs -I../../gst-libs
-D_REENTRANT -D_PTHREADS -I/local/gnu/include/gstreamer-0.10
-I/local/gnu/include/glib-2.0 -I/local/gnu/lib/64/glib-2.0/include
-I/local/gnu/include/libxml2 -g -DGSTLAME_PRESET -I/local/include/X11
-I/local/include -I/local/gnu/include/X11 -I/local/gnu/include -Xa -xO2
-xstrconst -KPIC -m64 -xtarget=native -xarch=native -c gstlame.c  -KPIC -DPIC
-o .libs/libgstlame_la-gstlame.o
"../../gst-libs/gst/gettext.h", line 45: warning: macro redefined: gettext
"../../gst-libs/gst/gettext.h", line 46: warning: macro redefined: dgettext
"../../gst-libs/gst/gettext.h", line 47: warning: macro redefined: dcgettext
"../../gst-libs/gst/gettext.h", line 48: warning: macro redefined: ngettext
"../../gst-libs/gst/gettext.h", line 50: warning: macro redefined: dngettext
"../../gst-libs/gst/gettext.h", line 52: warning: macro redefined: dcngettext
"../../gst-libs/gst/gettext.h", line 54: warning: macro redefined: textdomain
"../../gst-libs/gst/gettext.h", line 55: warning: macro redefined:
bindtextdomain
"../../gst-libs/gst/gettext.h", line 56: warning: macro redefined:
bind_textdomain_codeset
"gstlame.c", line 581: warning: assignment type mismatch:
        pointer to char "=" pointer to function(pointer to const char, ...)
returning pointer to char
"gstlame.c", line 581: syntax error before or at: 0L
"gstlame.c", line 584: cannot recover from previous errors
cc: acomp failed for gstlame.c


If I preprocess the file, I see that the macro expands to:

setup_failed:
  {
     if ( 1 ) { gchar * __txt = _gst_element_error_printf ( ( ( const char * )
( "Failed to configure LAME encoder. Check your encoding parameters." ) ) ) ;
gchar * __dbg = _gst_element_error_printf 0L ; if ( __txt ) if ( 1 ) { if ( (
GST_LEVEL_WARNING <= __gst_debug_min ) ) { gst_debug_log ( ( debug ) , (
GST_LEVEL_WARNING ) , "gstlame.c" , __func__ , 581 , ( GObject * ) ( lame ) ,
"error: %s" , __txt ) ; } } else ( void ) 0 ; if ( __dbg ) if ( 1 ) { if ( (
GST_LEVEL_WARNING <= __gst_debug_min ) ) { gst_debug_log ( ( debug ) , (
GST_LEVEL_WARNING ) , "gstlame.c" , __func__ , 581 , ( GObject * ) ( lame ) ,
"error: %s" , __dbg ) ; } } else ( void ) 0 ; gst_element_message_full ( ( ( (
( GstElement * ) g_type_check_instance_cast ( ( GTypeInstance * ) ( ( lame ) )
, ( ( gst_element_get_type ( ) ) ) ) ) ) ) , GST_MESSAGE_ERROR ,
gst_library_error_quark ( ) , GST_LIBRARY_ERROR_SETTINGS , __txt , __dbg ,
"gstlame.c" , __func__ , 581 ) ; } else ( void ) 0 ;
# 582
    return  ( 0 );
  }


The problem is the 0L after the _gst_element_error_printf.  Looking at the
macro for zero_output_rate, above the one for setup_failed, I see that the NULL
is in a different place in the argument list.  If I move it to look more like
that macro call, the compile proceeds.

Not sure if that's the right fix, if it is, I can provide a patch.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=517985.