[gstreamer-bugs] [Bug 469930] [mmssrc] seeking support PATCH

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=469930

  GStreamer | gst-plugins-bad | Ver: 0.10.5




------- Comment #13 from Hans de Goede  2008-02-22 06:30 UTC -------
(In reply to comment #11)
> Hm, there's no need to switch away from GstPushSrc and use GstBaseSrc directly
> if you want seeking support. MMS is still a "push" based protocol, right? ;)
> 
> Look at how the soup and neon plugins do it for example.
> 

So, to be clear, you want the patch to be changed to:
-not change the base class from pushsrc -> basesrc
-implement a do seek function todo the actual seeking, instead of seeking in
 create as its done in the current patch

Correct?


(In reply to comment #12)
> The ASF patch looks correct though, committed. (Well, it would also work to
> send a TIME based seek upstream instead of doing the CONVERT query, right?)
> 

Not at the moment, as currently except for supporting time -> bytes conversion
queries mmssrc still is completely bytes based and still only supports bytes
based seeking. Seeing how tightly mms <-> asf are married and how handling seek
queries is already done at the asf level I didn't see this as a problem, as
afaik the only downstream of mms will ever be asf and that already handles seek
queries, but maybe its trivial to add support for seekqueries somehow, letting
most of the work be done by basesrc?

Note: although I'm very interested in gstreamer development I'm as green as
gras when it comes to gstreamer internals like these.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=469930.