[gstreamer-bugs] [Bug 518162] New: Patch for GStreamer to handle italic text starting with "/" with MicroDVD subs

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=518162

  GStreamer | gst-plugins-base | Ver: 0.10.17
           Summary: Patch for GStreamer to handle italic text starting with
                    "/" with MicroDVD subs
           Product: GStreamer
           Version: 0.10.17
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: tsalacinski at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: 2.19/2.20
   GNOME milestone: Unspecified


This is diff for my patch for GStreamer to handle lines starting with "/"
(forward slash) - it means the line should be italic.

[tommy at Tommy-PC Pulpit]$ diff gstsubparse-original.c gstsubparse.c
446a447,454
> 
>     if (g_str_has_prefix (line, "/") == TRUE) {
>       italic = TRUE;
>       line = line + 1;
>     } 
>     if (g_str_has_suffix (line, "/") == TRUE) {
>       line = g_strndup(line, strlen(line) - 1);
>       }


The diff was made against gstreamer-plugins-base-0.10.17.

Example:

{1}{75}movie info: XVID  608x256 25.0fps 699.0 MB|/SubEdit b.4060
(http://subedit.com.pl)/

First line should not be affected. Second line should be italic, and forward
slashes at the beginning and the end should be removed. Also, the http://
forward slashes shouldn't be removed.

This patch does this, and AFAIK works properly.

Waiting for review.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=518162.