[gstreamer-bugs] [Bug 517813] [audioconvert] make gap aware

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=517813

  GStreamer | gst-plugins-base | Ver: HEAD CVS




------- Comment #8 from Stefan Kost (gstreamer, gtkdoc dev)  2008-02-25 13:47 UTC -------
* We would need to move
static const FormatDef xxx and build_linear_format() to e.g. audio_format.c.
* FormatDef should be renamed to e.g. GstAudioFormat (do we want that to be
opaque? - ringbuffer accesses the 'format' member). GstBufferFormat is a bit
ugly (should have been GstRingBufferFormat)
* build_linear_format() should be renamed to gst_audio_format_get()

* AudioConvertFmt could then call gst_audio_format_get() whenever the format
changes.

* audio_format.c should offer new api to clear a buffer: 
gst_audio_format_clear_memory(GstAudioFormat *def, guint8 *mem, gsize length)
{
  /* FIXME: what about having bytes as part of GstAudioFormat */
  bytes = spec->width >> 3;
  for (i = 0; i < length; i++) {
    for (j = 0; j < bytes; j++) {
      mem[i * bytes + j] = def->silence[j];
    }
  }
}

* this can be used by audioconvert to simplyfiy the current patch.
* it can be easily used by ringbuffer still.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=517813.