[gstreamer-bugs] [Bug 498924] deprecate GST_PLUGIN_DEFINE_STATIC because it's not portable

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=498924

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99507|accepted-commit_now         |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.16




------- Comment #12 from Tim-Philipp Müller  2008-01-09 18:31 UTC -------
Done:

 2008-01-09  Tim-Philipp Müller  <tim at centricular dot net>

        * docs/gst/gstreamer-sections.txt:
        * gst/gst.c: (init_post):
        * gst/gstplugin.c: (_gst_plugin_register_static),
          (gst_plugin_register_static), (_gst_plugin_initialize),
          (gst_plugin_register_func):
        * gst/gstplugin.h: (GST_PLUGIN_DEFINE_STATIC):
          API: add gst_plugin_register_static() and deprecate
          GST_PLUGIN_DEFINE_STATIC, since it's not portable
          (#498924).
          Also, in _gst_plugin_register_static(), make sure to call
          g_thread_init() before calling GLib functions such as
          g_list_append() if we're not initialised yet, since that
          may lead to random crashes with older GSlice/GLib versions.

        * tests/check/gst/gstplugin.c:
          Adapt unit test to above changes.

(For the record: the #ifndef GST_DISABLE_DEPRECATED in gstplugin.h shouldn't
cause problems with the icydemux unit test in gst-plugins-good if core is
released before the macro-less next -good, because the unit tests in -good are
not compiled with -DGST_DISABLE_DEPRECATED, unlike the plugins themselves).


> That's a problem.  Also, I'd be a lot more comfortable keeping the current
> behavior, i.e., that factory->plugin is never NULL, but plugin->module might
> be.  

That's not really the current behaviour AFAICT, since

  2007-05-12  David Schleef  <ds at schleef.org>

        * gst/gst.c:
          Add GST_DISABLE_OPTION_PARSING, in order to disable option
          parsing for embedded systems.
        * gst/gstelementfactory.c:
          Allow gst_element_register() to be called with plugin==NULL.
          Did nobody notice that static elements were broken?

got released with 0.10.13, so we can't really change it back now, can we?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=498924.