[gstreamer-bugs] [Bug 505417] Add GstPoll to core

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=505417

  GStreamer | gstreamer (core) | Ver: HEAD CVS




------- Comment #10 from Peter Kjellerstedt  2008-01-11 14:06 UTC -------
Created an attachment (id=102593)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=102593&action=view)
Convert gst-plugins-good/gst/udp to use GstPoll

This patch converts gst-plugins-good/gst/udp to use GstPoll. 

There was one weird thing in the old code. I can not really understand the
ratinale behind the following code:

#ifdef G_OS_WIN32
    if (((max_sock + 1) != READ_SOCKET (udpsrc)) ||
        ((max_sock + 1) != WRITE_SOCKET (udpsrc))) {
      ret = select (max_sock + 1, &read_fds, NULL, NULL, timeout);
    } else {
      ret = 1;
    }
#else

As far as I can tell that means the ret = 1; else clause should be taken if
max_sock + 1 == READ_SOCKET (udpsrc) && max_sock + 1 == WRITE_SOCKET (udpsrc),
something which can never happen. So I removed that special treatment for
W32...


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=505417.