[gstreamer-bugs] [Bug 508595] [lame] wrong output caps in mono encoding mode

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=508595

  GStreamer | gst-plugins-ugly | Ver: 0.10.6




------- Comment #3 from Mark Nauwelaerts  2008-01-12 09:41 UTC -------
lame_encode_buffer/flush (lame API calls) return number of mp3 (encoded) bytes,
so a calculation based on it using samplerate (etc) does not make sense. 
However, (assuming CBR) based on bitrate (etc) does make sense (as it has been
changed to in EOS event handling).
On the other hand, in gst_lame_chain, duration calculation is based on the
input buffer size (not mp3 buffer), so it makes sense there to use samplerate.

[Using (possibly delayed) input buffer sizes for output buffer ones seems more
or less approximate but OK, and can also handle VBR cases, but minor errors
might accumulate up to the last-to-be-flushed buffer.  There is also no input
buffer that can be used when receiving EOS, hence best shot fall-back to mp3
buffer size]


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=508595.