[gstreamer-bugs] [Bug 510505] New: changes to make v4l plugin build on solaris

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=510505

  GStreamer | gst-plugins-good | Ver: HEAD CVS
           Summary: changes to make v4l plugin build on solaris
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: opensolaris
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: brian.cameron at sun.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: 2.21/2.22
   GNOME milestone: Unspecified


The attached patch is needed to make the v4l2 plugin to build on Solaris.
Note that the main difference is that the videodev2 header file is in
a different location and you need a few more #includes.

Also note the change to gstv4l2colorbalance.h file.  This is needed because
void functions can't return values.

Can these changes go upstream.

Note to build v4l2 on Solaris, the configure.ac script needs to be hacked since
it currently tries to compile code that includes "linux/types.h" and
"linux/videodev2.h".  On Solaris you do not need to include "linux/types.h"
and you include "sys/videodev2.h" instead of "linux/videodev2.h".  I'm not sure
the best way to hack the configure.ac script to make it work on Solaris.  Any
ideas?

Perhaps it might be easiest to just make it look like this:

AG_GST_CHECK_FEATURE(GST_V4L2, [Video 4 Linux 2], v4l2src, [
  AC_MSG_CHECKING([Checking for uptodate v4l2 installation])
  AC_TRY_COMPILE([
#include <sys/types.h>
#ifndef __sun
#include <linux/types.h>
#endif
#define _LINUX_TIME_H
#define __user
#ifdef __sun
#include <sys/videodev2.h>
#else
#include <linux/videodev2.h>
#endif
#if defined(V4L2_MAJOR_VERSION) || defined(V4L2_MINOR_VERSION)
#error too early v4l2 version or no v4l2 at all
#endif

What do you think?  I can provide a patch to do this, or you can just make the
minor change yourself.  Note that the check for linux/videodev2.h is done in 3
places in configure.ac.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=510505.