[gstreamer-bugs] [Bug 513628] New: [PATCH] Decoding of PICTURE blocks in FLAC is always disabled by bad ifdef

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=513628

  GStreamer | gst-plugins-good | Ver: HEAD CVS
           Summary: [PATCH] Decoding of PICTURE blocks in FLAC is always
                    disabled by bad ifdef
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: jmillikin at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: 2.21/2.22
   GNOME milestone: Unspecified


Please describe the problem:
In gstflacdec.c, decoding of PICTURE blocks is guarded against compilation with
old FLAC libraries using an #ifdef. However, the #ifdef checks against the
always-absent define FLAC__METADATA_TYPE_PICTURE (which is actually an enum
value). Instead, it should use the LEGACY_FLAC macro defined in gstflacdec.h.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=513628.