[gstreamer-bugs] [Bug 541412] New: cross mingw32 gcc: making libgstrtp plugin compile

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=541412

  GStreamer | gst-plugins-good | Ver: HEAD CVS
           Summary: cross mingw32 gcc: making libgstrtp plugin compile
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: damien.lespiau at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Symptom: when cross-compiling with mingw32 from a linux box, it stops with:

/home/damien/src/build-gst-plugins-good-0.10.8/gst/rtp/../../../gst-plugins-good-0.10.8/gst/rtp/gstasteriskh263.c:207:
undefined reference to `_htonl at 4'
/home/damien/src/build-gst-plugins-good-0.10.8/gst/rtp/../../../gst-plugins-good-0.10.8/gst/rtp/gstasteriskh263.c:208:
undefined reference to `_htons at 4'

because htonl and htons are defined in ws2_32.dll.

If you look at the makefile WINSOCK2_LIBS should be set correctly:

if HAVE_WINSOCK2_H
WINSOCK2_LIBS = -lws2_32
else
WINSOCK2_LIBS =
endif

but it's not: (gst/rtp/Makefile)

WINSOCK2_LIBS = 
#WINSOCK2_LIBS = -lws2_32

This is because of a wrong use of the pair AC_CHECK_HEADERS/AM_CONDITIONAL
AC_CHECK_HEADERS([winsock2.h])
AM_CONDITIONAL(HAVE_WINSOCK2_H, test "x$HAVE_WINSOCK2_H" = "xyes")

(the AC_CHECK_HEADERS lacks the script part that set HAVE_WINSOCK2_H)

-------

The proposed patch adds a HAVE_WINSOCK2_H=yes in the above AC_CHECK_HEADERS but
one could prefer relying on WIN32_LIBS defined later in the configure.ac file.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=541412.