[gstreamer-bugs] [Bug 541543] New: fix HAVE_OSS4 detection code in configure.ac

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=541543

  GStreamer | gst-plugins-bad | Ver: HEAD CVS
           Summary: fix HAVE_OSS4 detection code in configure.ac
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Windows
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: damien.lespiau at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Building -bad with mingw32 triggers a bug in the way the configure script
decide if the OSS4 plugin can be built.

The following use of AG_GST_CHECK_FEATURE won't work as expected: 

AG_GST_CHECK_FEATURE(OSS4, [Open Sound System 4], oss4, [
   AC_MSG_CHECKING([Checking if we can build the OSS4 elements])
   AC_CHECK_HEADERS([fcntl.h sys/ioctl.h sys/stat.h sys/types.h],
      [HAVE_OSS4="yes"], [HAVE_OSS4="no"])
])

AG_GST_CHECK_FEATURE wants to have either HAVE_XXX=yes or HAVE_XXX=no at the
end of the day. AC_CHECK_HEADERS executes either HAVE_OSS4=yes or HAVE_OSS4=no
for each header specified. When building for windows with mingw32 we do have
fcntl.h, sys/stat.h and sys/types.h but not ioctl.h and then the value of
HAVE_OSS4 goes like this:
HAVE_OSS4=yes
HAVE_OSS4=no (sys/ioctl.h check)
HAVE_OSS4=yes
HAVE_OSS4=yes

thus the configure script is telling automake the OSS4 plugin can be built.
(yes HAVE_OSS4 is overwritten by the tests of sys/stat.h and sys/types.h)

----

The following patch fix the issue (I tested the newly created configure script
with a cross mingw32-gcc and with the native gcc of a linux box)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=541543.