[gstreamer-bugs] [Bug 432755] [videorate] leaks buffer if flow != OK

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=432755

  GStreamer | gst-plugins-base | Ver: 0.10.x

Stefan Kost (gstreamer, gtkdoc dev) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ensonic at sonicpulse.de
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




------- Comment #3 from Stefan Kost (gstreamer, gtkdoc dev)  2008-07-10 14:03 UTC -------
Today one IRC:
15:19 < yves> Hi : I have a question about a past fix for a leak in videorate :
bug 432755 fix rev 1.50 of gstvideorate.c : the fix is about 
              unrefing a gst-buffer when pad_push return != GST_FLOW_OK
15:20 < yves> However, according to the doc, the pad_push function should take
the ownership of the buffer in all case.
15:20 < yves> So, I think this fix may not be done at the right place. Maybe
there is something in the gstreamer mechanic that is causing 
              this buffer leak

>From briefly lloking at it, it indeed looks suspicious.
http://webcvs.freedesktop.org/gstreamer/gst-plugins-base/gst/videorate/gstvideorate.c?view=markup

gst_video_rate_flush_prev() is called several time, but only in one place
(chain()) the return value is checked. Maybe gst_video_rate_flush_prev() should
unref the buffer if its not pushing it (eos_before_buffers), so that it like
pad_push() takes ownership.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=432755.