[gstreamer-bugs] [Bug 542510] [apexsink] Apple AirPort Express Wireless Sink

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=542510

  GStreamer | gst-plugins-bad | Ver: 0.10.15

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at circular-chaos.org
         AssignedTo|gstreamer-                  |slomo at circular-chaos.org
                   |bugs at lists.sourceforge.net  |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1




------- Comment #2 from Sebastian Dröge  2008-07-13 20:44 UTC -------
Just some random notes, I'll take a closer look tomorrow:

- Could you attach it as a diff to gst-plugins-bad, including build system
modifications?
- Why exactly is the openssl needed? It might make sense to use GnuTLS or
libgcrypt instead for license reasons
- No // comments, please use /* */ comments instead, there are still some
compilers that don't like them in C code
- Add your real name at the head of the source code files for the copyright.
some nickname won't give you anything
- You could use the GLib base64 implementation instead of your own
- Where does the AES code come from? Also, doesn't openssl/libgcrypt provide
this already anyway? :)
- No declarations after statements, i.e. move all variable declarations at the
start of a block (same reason as for the // comments)

Apart from that the code looks really good and clean, I like it :)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=542510.