[gstreamer-bugs] [Bug 542510] [apexsink] Apple AirPort Express Wireless Sink

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=542510

  GStreamer | gst-plugins-bad | Ver: 0.10.15




------- Comment #4 from GRemi  2008-07-16 10:06 UTC -------
    > - Could you attach it as a diff to gst-plugins-bad, including build
system
    > modifications?

    I'll do the diff once the other points done ans the sink ready.

    > - Why exactly is the openssl needed? It might make sense to use GnuTLS or
    > libgcrypt instead for license reasons

    Sure. I'll work on the gcrypt use instead of openssl (random bytes
generation,
    RSA public key encryption).

    > - No // comments, please use /* */ comments instead, there are still some
    > compilers that don't like them in C code

    This is my C++ habits... I'll substitute the //. 

    > - Add your real name at the head of the source code files for the
copyright.
    > some nickname won't give you anything

    That is the point : RAOP is an Apple protocol which overlaps RTSP (as far
as I
    know, it has not been published yet) with an extra challenge-response RSA
based
    authentication step. The public key has been extracted by Jon Lech Johansen
    enabling theard party software to stream data to an AirPort Express
(emulating
    an iTunes identification). I'm not sure this is perfectly legal. What do
you
    think about that ?

    > - You could use the GLib base64 implementation instead of your own

    I had the statements and made a copy/paste, unpatient to see if the sink
was
    working... I'll replace the base64 with the glib's one.

    > - Where does the AES code come from? Also, doesn't openssl/libgcrypt
provide
    > this already anyway? :)

    It seems that gcrypt now provides the Rijndael algorithm. The AES code
comes
    from a published Rijndael C++ class (I've forgotten the exact source I
found).
    Anyway,  I'll do some investigations to see how to use gcrypt on this
point.

    > - No declarations after statements, i.e. move all variable declarations
at the
    > start of a block (same reason as for the // comments)

    C++ habits once again... I'll move the declarations.

    > Apart from that the code looks really good and clean, I like it :) 

    Thank you very much for for your advise and your time. 


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=542510.